Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] refactor _signatures_with_internal #1896

Merged
merged 3 commits into from
Mar 27, 2022
Merged

[MRG] refactor _signatures_with_internal #1896

merged 3 commits into from
Mar 27, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 25, 2022

Extracting this from #1891.

This PR simplifies the internal API _signatures_with_location() and its use in creating manifests.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1896 (de55892) into latest (ffbc919) will increase coverage by 7.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1896      +/-   ##
==========================================
+ Coverage   82.75%   90.65%   +7.90%     
==========================================
  Files         122       92      -30     
  Lines       13206     9001    -4205     
  Branches     1780     1779       -1     
==========================================
- Hits        10928     8160    -2768     
+ Misses       2014      577    -1437     
  Partials      264      264              
Flag Coverage Δ
python 90.65% <100.00%> (-0.01%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/index/__init__.py 96.45% <100.00%> (ø)
src/sourmash/lca/lca_db.py 91.27% <100.00%> (ø)
src/sourmash/sbt.py 85.33% <100.00%> (ø)
src/sourmash/sourmash_args.py 93.50% <100.00%> (-0.04%) ⬇️
src/core/tests/test.rs
src/core/src/ffi/index/revindex.rs
src/core/src/ffi/minhash.rs
src/core/src/sketch/nodegraph.rs
src/core/tests/storage.rs
src/core/src/signature.rs
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbc919...de55892. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Mar 25, 2022

Ready for review @sourmash-bio/devs. Note this is an internal API (that is also pretty well tested ;).

@ctb ctb merged commit aef0036 into latest Mar 27, 2022
@ctb ctb deleted the refactor/mf_internal branch March 27, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants