Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Convert nix to flakes #1904

Merged
merged 1 commit into from
Mar 26, 2022
Merged

[MRG] Convert nix to flakes #1904

merged 1 commit into from
Mar 26, 2022

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Mar 26, 2022

Flakes are a new way of specifying Nix tasks (dev deps, package building, applications) and make it easier to be imported in other projects.

With a recent version on nix this already works:

nix run github:sourmash-bio/sourmash/lirber/nix_flake

and once the PR is merged then

nix run github:sourmash-bio/sourmash

will also work.

TODO

  • Update CI
  • Update docs

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #1904 (b7fd3b9) into latest (1b6d9e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #1904   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         122      122           
  Lines       13206    13206           
  Branches     1780     1780           
=======================================
  Hits        10928    10928           
  Misses       2014     2014           
  Partials      264      264           
Flag Coverage Δ
python 90.65% <ø> (ø)
rust 65.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6d9e1...b7fd3b9. Read the comment docs.

@luizirber luizirber changed the title [WIP] Convert nix to flakes [MRG] Convert nix to flakes Mar 26, 2022
@luizirber luizirber requested a review from a team March 26, 2022 23:00
@luizirber luizirber merged commit ffbc919 into latest Mar 26, 2022
@luizirber luizirber deleted the lirber/nix_flake branch March 26, 2022 23:01
@ctb
Copy link
Contributor

ctb commented Mar 27, 2022

did you mean to add Cargo.lock in this PR?

@luizirber
Copy link
Member Author

did you mean to add Cargo.lock in this PR?

Yes, to make the builds reproducible (dependencies version-wise). The additional step is probably using --locked when calling cargo in setup.py, so the lockfile isn't updated automatically when building the Rust extension (and using dependabot for bumping versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants