Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix sig check manifest rebuilding #1915

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[MRG] fix sig check manifest rebuilding #1915

merged 1 commit into from
Mar 30, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Mar 30, 2022

Per #1907 (comment), fix sig check to not rebuild manifests every time! 🙄

@ctb
Copy link
Contributor Author

ctb commented Mar 30, 2022

(should be ready for review & merge @bluegenes)

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1915 (afe243d) into latest (3b267fe) will increase coverage by 7.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1915      +/-   ##
==========================================
+ Coverage   82.96%   90.83%   +7.87%     
==========================================
  Files         123       93      -30     
  Lines       13365     9165    -4200     
  Branches     1808     1808              
==========================================
- Hits        11088     8325    -2763     
+ Misses       2013      576    -1437     
  Partials      264      264              
Flag Coverage Δ
python 90.83% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/sig/check.py 100.00% <100.00%> (ø)
src/sourmash/sig/__main__.py 93.56% <100.00%> (ø)
src/sourmash/sourmash_args.py 93.40% <100.00%> (+0.01%) ⬆️
src/core/src/index/linear.rs
src/core/src/storage.rs
src/core/src/errors.rs
src/core/src/from.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/index/revindex.rs
src/core/src/ffi/cmd/compute.rs
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b267fe...afe243d. Read the comment docs.

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻!

@ctb ctb merged commit 51ba09e into latest Mar 30, 2022
@ctb ctb deleted the fix/sig_check_manifest branch March 30, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants