Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add some tests for Jaccard output ordering #1926

Merged
merged 6 commits into from
Apr 10, 2022
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 3, 2022

This PR adds tests for optimized search Index classes (SBT and LCA_Database, currently) that ensure that we do not erroneously truncate searches. See #1925 for details.

tl;dr more tests good.

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #1926 (70121b2) into latest (d1d8397) will increase coverage by 8.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #1926      +/-   ##
==========================================
+ Coverage   82.93%   90.96%   +8.03%     
==========================================
  Files         125       94      -31     
  Lines       13755     9479    -4276     
  Branches     1877     1877              
==========================================
- Hits        11408     8623    -2785     
+ Misses       2075      584    -1491     
  Partials      272      272              
Flag Coverage Δ
python 90.96% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/lca/lca_db.py 91.30% <ø> (ø)
src/core/src/ffi/index/revindex.rs
src/core/src/ffi/nodegraph.rs
src/core/src/errors.rs
src/core/src/ffi/signature.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/lib.rs
src/core/src/encodings.rs
src/core/src/index/bigsi.rs
src/core/src/cmd.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d8397...70121b2. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Apr 8, 2022

ready for review & merge @sourmash-bio/devs

Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are looking good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants