Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] catch TypeError in search w/abund vs flat at the command line #1928

Merged
merged 6 commits into from
Apr 15, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 4, 2022

This PR adjusts search to catch an exception that shouldn't be exposed to the user; here the exception is caused by searching a flat database with an abund signature.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #1928 (1797943) into latest (f0726c3) will increase coverage by 8.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1928      +/-   ##
==========================================
+ Coverage   82.94%   90.97%   +8.03%     
==========================================
  Files         125       94      -31     
  Lines       13759     9483    -4276     
  Branches     1877     1877              
==========================================
- Hits        11412     8627    -2785     
+ Misses       2075      584    -1491     
  Partials      272      272              
Flag Coverage Δ
python 90.97% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/commands.py 88.55% <100.00%> (+0.05%) ⬆️
src/core/src/index/mod.rs
src/core/src/cmd.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/ffi/storage.rs
src/core/src/index/revindex.rs
src/core/src/index/search.rs
src/core/src/ffi/nodegraph.rs
src/core/src/signature.rs
src/core/src/ffi/minhash.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0726c3...1797943. Read the comment docs.

@ctb ctb changed the title [WIP] catch TypeError in search w/abund vs flat [MRG catch TypeError in search w/abund vs flat Apr 5, 2022
@ctb
Copy link
Contributor Author

ctb commented Apr 5, 2022

@sourmash-bio/devs ready for review & merge!

@ctb ctb changed the title [MRG catch TypeError in search w/abund vs flat [MRG] catch TypeError in search w/abund vs flat at the command line Apr 6, 2022
@ctb
Copy link
Contributor Author

ctb commented Apr 8, 2022

still ready for review & merge @sourmash-bio/devs :)

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bluegenes bluegenes merged commit 0d04cca into latest Apr 15, 2022
@bluegenes bluegenes deleted the fix/search_type_error branch April 15, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants