Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for seq_to_hashes in protein mode #1944

Merged
merged 3 commits into from
Apr 10, 2022

Conversation

luizirber
Copy link
Member

Add some rust benchmarks for seq_to_hashes in protein mode, so we don't regress after the awesome progress in #1938

Other fixes:

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1944 (a6e0297) into latest (03f504e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           latest    #1944   +/-   ##
=======================================
  Coverage   82.93%   82.93%           
=======================================
  Files         125      125           
  Lines       13755    13755           
  Branches     1877     1877           
=======================================
  Hits        11408    11408           
  Misses       2075     2075           
  Partials      272      272           
Flag Coverage Δ
python 90.96% <100.00%> (ø)
rust 65.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/command_compute.py 92.87% <100.00%> (ø)
src/sourmash/command_sketch.py 93.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f504e...a6e0297. Read the comment docs.

@luizirber luizirber force-pushed the lirber/seq_to_hashes_protein branch from a54da58 to a6e0297 Compare April 10, 2022 20:31
@luizirber luizirber changed the title [WIP] Benchmarks for seq_to_hashes in protein mode Benchmarks for seq_to_hashes in protein mode Apr 10, 2022
@luizirber luizirber merged commit 01119a2 into latest Apr 10, 2022
@luizirber luizirber deleted the lirber/seq_to_hashes_protein branch April 10, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

benchmark cmd tox -e asv requires python=3.10
2 participants