Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] rename containment to contained_by #199

Merged
merged 52 commits into from
May 24, 2017
Merged

[MRG] rename containment to contained_by #199

merged 52 commits into from
May 24, 2017

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 1, 2017

We found that containment was confusing, so we renamed it to contained_by.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

ctb and others added 30 commits April 16, 2017 18:39
@codecov-io
Copy link

codecov-io commented May 14, 2017

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   86.22%   86.22%           
=======================================
  Files          13       13           
  Lines        1974     1974           
  Branches       52       52           
=======================================
  Hits         1702     1702           
  Misses        262      262           
  Partials       10       10
Impacted Files Coverage Δ
sourmash_lib/commands.py 90.19% <100%> (ø) ⬆️
sourmash_lib/signature.py 93.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbef79a...150a0f2. Read the comment docs.

@ctb ctb changed the title [WIP] fixes needed for spacegraphcats [MRG] fixes needed for spacegraphcats May 21, 2017
@ctb ctb changed the title [MRG] fixes needed for spacegraphcats [MRG] rename containment to contained_by May 23, 2017
@ctb
Copy link
Contributor Author

ctb commented May 23, 2017

Ready for review & merge!

@luizirber luizirber merged commit f76938e into master May 24, 2017
@luizirber
Copy link
Member

Do you want to keep the spacegraphcats branch around?

@ctb
Copy link
Contributor Author

ctb commented May 24, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants