Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] provide minimum sourmash version information about sketch fromfile #2009

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 28, 2022

Fixes #2007.

Also squashes toctree warnings during doc build.

@mr-eyes should be ready for review!

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2009 (d7a93d6) into latest (14f3d7a) will increase coverage by 7.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2009      +/-   ##
==========================================
+ Coverage   84.14%   91.66%   +7.52%     
==========================================
  Files         129       98      -31     
  Lines       15082    10802    -4280     
  Branches     2118     2118              
==========================================
- Hits        12691     9902    -2789     
+ Misses       2095      604    -1491     
  Partials      296      296              
Flag Coverage Δ
python 91.66% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/ffi/minhash.rs
src/core/src/index/linear.rs
src/core/src/from.rs
src/core/src/storage.rs
src/core/src/errors.rs
src/core/src/cmd.rs
src/core/src/sketch/minhash.rs
src/core/src/encodings.rs
src/core/src/index/sbt/mod.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f3d7a...d7a93d6. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Apr 28, 2022

@sourmash-bio/devs ready for review and (maybe) merge! this is a nice easy one! get your reviewing credits in here!

Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ctb ctb merged commit 69ebe53 into latest Apr 28, 2022
@ctb ctb deleted the update/fromfile_doc_version branch April 28, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourmash sketch fromfile missing in v4.3?
2 participants