Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add sig collect command #2036

Merged
merged 27 commits into from
May 13, 2022
Merged

[MRG] add sig collect command #2036

merged 27 commits into from
May 13, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 5, 2022

Adds sourmash sig collect by integrating sigs-to-manifest.py into sourmash.

This is the code that's used to maintain a manifest of wort-genomes signatures, among other things - see #1965.

The main motivation behind this command addition is that it's really enabling for certain use cases, as shown most clearly by the way the documentation simplifies 😃 .

Guide into rendered docs from this PR:

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2036 (521788e) into latest (06989d7) will increase coverage by 7.57%.
The diff coverage is 99.15%.

@@            Coverage Diff             @@
##           latest    #2036      +/-   ##
==========================================
+ Coverage   84.16%   91.73%   +7.57%     
==========================================
  Files         129       99      -30     
  Lines       15134    10960    -4174     
  Branches     2133     2151      +18     
==========================================
- Hits        12737    10054    -2683     
+ Misses       2098      607    -1491     
  Partials      299      299              
Flag Coverage Δ
python 91.73% <99.15%> (+0.08%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/index/sqlite_index.py 92.07% <96.00%> (+0.34%) ⬆️
src/sourmash/cli/sig/__init__.py 100.00% <100.00%> (ø)
src/sourmash/cli/sig/collect.py 100.00% <100.00%> (ø)
src/sourmash/manifest.py 94.89% <100.00%> (+0.07%) ⬆️
src/sourmash/sig/__main__.py 94.00% <100.00%> (+0.45%) ⬆️
src/core/tests/minhash.rs
src/core/src/index/mod.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/tests/storage.rs
src/core/src/from.rs
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06989d7...521788e. Read the comment docs.

@ctb ctb changed the title [WIP] add sig collect command [MRG] add sig collect command May 8, 2022
@ctb
Copy link
Contributor Author

ctb commented May 8, 2022

Ready for review & merge @sourmash-bio/devs!

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple minor suggestions, otherwise lgtm!

src/sourmash/sig/__main__.py Outdated Show resolved Hide resolved
tests/test_cmd_signature_collect.py Outdated Show resolved Hide resolved
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
ctb and others added 2 commits May 12, 2022 19:09
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
@ctb
Copy link
Contributor Author

ctb commented May 13, 2022

thank you :)

@ctb ctb merged commit 7826fbc into latest May 13, 2022
@ctb ctb deleted the add/sig_collect branch May 13, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants