[MRG] rename covered_bp property to better reflect function
#2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2050 +/- ##
==========================================
+ Coverage 84.27% 91.73% +7.46%
==========================================
Files 130 99 -31
Lines 15240 10959 -4281
Branches 2151 2151
==========================================
- Hits 12843 10053 -2790
+ Misses 2098 607 -1491
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bluegenes
changed the title
covered_bp property to better reflect functioncovered_bp property to better reflect function
ctb
approved these changes
May 13, 2022
|
Thanks! Yep - no change to output, just more accurate/specific/intuitive(?) internal names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
covered_bpproperty tounique_dataset_hashesto reflect the fact that it does not take into account abundances and does not include+(k-1)for bp conversion. While this is currently an estimate ofscaled * len(self.hashes), this could be replaced by a more accurate count/estimate in the future (e.g. HLL, ref #2030).I also rename the
intersect_bpproperty ofFracMinHashComparisontototal_unique_intersect_hashesto be a bit clearer that we're working in hashes. Wrote a comment that this is approx equal tointersect_bp.Open to better names, ofc -- please suggest if you have them.
This is the simplified version of #2027.