Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix thresholds in distance_utils #2060

Merged
merged 1 commit into from
May 20, 2022
Merged

[MRG] fix thresholds in distance_utils #2060

merged 1 commit into from
May 20, 2022

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented May 19, 2022

The distance thresholds in the original distance utils equations were creating some issues -- this PR only skips distance estimation if jaccard/containment are actually 0 or 1.

ref: mahmudhera/phylogenetic-tree-using-fracminhash#2

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2060 (304b44f) into latest (3827367) will increase coverage by 7.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2060      +/-   ##
==========================================
+ Coverage   84.28%   91.74%   +7.45%     
==========================================
  Files         130       99      -31     
  Lines       15256    10976    -4280     
  Branches     2155     2155              
==========================================
- Hits        12859    10070    -2789     
+ Misses       2098      607    -1491     
  Partials      299      299              
Flag Coverage Δ
python 91.74% <100.00%> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/distance_utils.py 99.39% <100.00%> (ø)
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/errors.rs
src/core/src/sketch/minhash.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/cmd.rs
src/core/src/ffi/index/mod.rs
src/core/src/from.rs
src/core/src/index/mod.rs
src/core/src/ffi/cmd/compute.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3827367...304b44f. Read the comment docs.

@bluegenes
Copy link
Contributor Author

ready for review @ctb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants