Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] begin adding the machinery for CSV column renaming #2274

Open
wants to merge 3 commits into
base: latest
Choose a base branch
from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 8, 2022

Tackling #1555

TODO:

  • provide column documentation for v5

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #2274 (5bbe178) into latest (a8bd648) will increase coverage by 7.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2274      +/-   ##
==========================================
+ Coverage   84.82%   92.15%   +7.32%     
==========================================
  Files         131      100      -31     
  Lines       15676    11406    -4270     
  Branches     2251     2252       +1     
==========================================
- Hits        13297    10511    -2786     
+ Misses       2085      601    -1484     
  Partials      294      294              
Flag Coverage Δ
python 92.15% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/commands.py 90.12% <ø> (ø)
src/sourmash/cli/gather.py 100.00% <100.00%> (ø)
src/sourmash/search.py 97.97% <100.00%> (+0.02%) ⬆️
src/core/src/ffi/minhash.rs
src/core/src/index/revindex.rs
src/core/src/ffi/mod.rs
src/core/src/ffi/nodegraph.rs
src/core/src/index/linear.rs
src/core/src/ffi/utils.rs
src/core/src/index/search.rs
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant