WIP: remove version retrieval exception handling code #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2491 +/- ##
==========================================
+ Coverage 84.72% 92.52% +7.80%
==========================================
Files 132 103 -29
Lines 14731 11936 -2795
Branches 2503 2503
==========================================
- Hits 12481 11044 -1437
+ Misses 1948 590 -1358
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
luizirber
reviewed
Feb 22, 2023
| @@ -16,6 +16,7 @@ class MinHash - hash sketch class | |||
| BSD 3-Clause license. | |||
| """ | |||
| from deprecation import deprecated | |||
| from pkg_resources import get_distribution | |||
There was a problem hiding this comment.
Suggested change
| from pkg_resources import get_distribution | |
| from importlib.metadata import version |
(maybe add fallbacks for py3.8 too)
luizirber
reviewed
Feb 22, 2023
| "This might be because you are installing from GitHub's tarballs, " | ||
| "use the PyPI ones." | ||
| ) | ||
| VERSION = get_distribution(__name__).version |
There was a problem hiding this comment.
Suggested change
| VERSION = get_distribution(__name__).version | |
| VERSION = version(__name__) |
luizirber
added a commit
that referenced
this pull request
Mar 5, 2023
Close #2491 Similar to dib-lab/screed#100 but also dealing with `entry_points` (and the differences in stdlib for [`importlib.metadata`](https://pypi.org/project/backports.entry-points-selectable/)...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some outdated code per #2425 (comment), looking to see what happens if I remove it ;).