-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: LineageTree class to help with LINGroup ordering #2496
Conversation
Codecov Report
@@ Coverage Diff @@
## lins-v2 #2496 +/- ##
===========================================
+ Coverage 85.06% 92.75% +7.69%
===========================================
Files 133 104 -29
Lines 15036 12260 -2776
Branches 2575 2582 +7
===========================================
- Hits 12790 11372 -1418
+ Misses 1944 586 -1358
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@ctb sub-PR ready for review. In main LINS PR, I copied over the The diff here ~clearly shows the code reorganization and that the same tests pass for |
upd: decided to remove the |
Note: based off of #2469
build_tree
,find_lca
functions asLineageTree
class. Using same tests, we produce same resultsordered_paths
method to produce ~ordered lineages from tree for LINgroup ordered output.num_bp_assigned
column because it was artificial anyway (our counts are all assigned at the genome level) and we're not trying to replicate a format exactly, as we are withkreport
output, where we have this column.Note that LINgroups will not be ordered absolutely, as there will be some stochasticity as we descend the dictionary. Instead, related subpaths will be grouped.
e.g. two potential outputs:
In these examples, the
1;0
.. paths are always grouped together, but may come before or after the0;0
and2;0
groups