build: updates spun off mastiff PR #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizirber
force-pushed
the
lirber/202308_build_updates
branch
from
23205d5 to
41303aa
Compare
Codecov Report
@@ Coverage Diff @@
## latest #2723 +/- ##
=======================================
Coverage 85.27% 85.27%
=======================================
Files 133 133
Lines 15191 15191
Branches 2614 2614
=======================================
Hits 12954 12954
Misses 1936 1936
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
luizirber
force-pushed
the
lirber/202308_build_updates
branch
2 times, most recently
from
7a9cfa8 to
1c24f6c
Compare
luizirber
force-pushed
the
lirber/202308_build_updates
branch
from
1c24f6c to
75c0eff
Compare
|
Ready for review and merge @sourmash-bio/devs |
luizirber
force-pushed
the
lirber/202308_build_updates
branch
from
75c0eff to
c1a7825
Compare
|
Note, this also adds Update: ahh, had not gotten to #2724 yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(There are too many things happening in #2230, so I'll open a couple of PRs to simplify it)
tox 4, but keep usingtox 3untiltox-condais compatible withtox 4. Ended up adding an explicit'tox>=3.27,<4'to the conda dev env instructions to get the right version, and remove/replace deprecated options fromtox.iniMACOSX_DEPLOYMENT_TARGETto11.0consistently for maturin and CI.flake.nixand avoidnaersk, prefer regularnixpkgstooling now that python3Packages.sourmash: init at 4.8.3 NixOS/nixpkgs#230596 is merged and we can keep them in sync.ci/install_cargo.shintocibuildwheelconfiguration, set up extra tools needed forbindgen/cbindgen(libclang and env vars)