Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BIGSI and SBT code from Rust layer #2732

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Aug 23, 2023

(spun off #2230, might help with #2665)

BIGSI and SBT are prototype-level code (and some of the first Rust code I wrote...), and mostly makes it harder to change/refactor other parts of the codebase.

Can bring it back later in the future if needed, but mastiff cover many of the same use cases.

(CTB note Sep 17 2023: SBTs are still available in the Python code and in sourmash!)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2732 (155d39e) into latest (d0e3726) will increase coverage by 0.55%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           latest    #2732      +/-   ##
==========================================
+ Coverage   85.34%   85.89%   +0.55%     
==========================================
  Files         133      130       -3     
  Lines       15193    14788     -405     
  Branches     2614     2614              
==========================================
- Hits        12966    12702     -264     
+ Misses       1926     1785     -141     
  Partials      301      301              
Flag Coverage Δ
hypothesis-py 25.80% <ø> (ø)
python 92.83% <ø> (ø)
rust 49.81% <0.00%> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/src/index/mod.rs 0.00% <0.00%> (-39.19%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luizirber luizirber merged commit ba581ea into latest Aug 27, 2023
34 of 35 checks passed
@luizirber luizirber deleted the lirber/delete_sbt_bigsi branch August 27, 2023 15:01
@ctb ctb changed the title Remove BIGSI and SBT code Remove BIGSI and SBT code from Rust layer Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant