Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: 4.8.5 release branch #2876

Merged
merged 2 commits into from
Dec 12, 2023
Merged

MRG: 4.8.5 release branch #2876

merged 2 commits into from
Dec 12, 2023

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Dec 12, 2023

No description provided.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a1e554) 86.30% compared to head (16fce70) 86.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2876   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         135      135           
  Lines       15307    15307           
  Branches     2622     2622           
=======================================
  Hits        13211    13211           
  Misses       1796     1796           
  Partials      300      300           
Flag Coverage Δ
hypothesis-py 25.80% <ø> (ø)
python 92.82% <ø> (ø)
rust 58.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb
Copy link
Contributor Author

ctb commented Dec 12, 2023

hmm, it looks like wheels are still attempting to be built even for platforms where they were suppose to be disabled?

viz #2857

@ctb
Copy link
Contributor Author

ctb commented Dec 12, 2023

@luizirber is it ok to disable wheel building for linux-ppc64le and linux-s390x for releases, or is that something that should be working?

@ctb
Copy link
Contributor Author

ctb commented Dec 12, 2023

Here's the list of wheels now generated for each release - so we've dropped 4, down to 5 from 9. I think that's OK tho?

Screenshot 2023-12-12 at 11 22 53 AM

@ctb
Copy link
Contributor Author

ctb commented Dec 12, 2023

I think I'll go ahead and merge. We can always add wheels to the release later.

@ctb ctb merged commit 5ae9ebc into latest Dec 12, 2023
42 checks passed
@ctb ctb deleted the release/v4.8.5 branch December 12, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant