Implement file parsing for webassembly #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3047 +/- ##
=======================================
Coverage 86.88% 86.89%
=======================================
Files 136 136
Lines 15543 15542 -1
Branches 2637 2637
=======================================
Hits 13505 13505
+ Misses 1736 1735 -1
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luizirber
force-pushed
the
lirber/wasm_needletail
branch
from
40f87ed
to
5719935
Compare
luizirber
force-pushed
the
lirber/wasm_needletail
branch
from
57a2c90
to
6153730
Compare
ctb
added a commit
that referenced
this pull request
Apr 9, 2024
Release candidate testing: - [x] Command line tests pass for a release candidate - [x] All eight release candidate wheels are built Releasing to PyPI: - [ ] RC tag(s)s deleted on github - [ ] Release tag cut - [ ] Release notes written - [ ] All eight release wheels built - [ ] Release wheels uploaded to pypi - [ ] tar.gz distribution uploaded to pypi After release to PyPI and conda-forge/bioconda packages built: - [ ] [PyPI page](https://pypi.org/project/sourmash/) updated - [ ] Zenodo DOI successfully minted upon new github release - [see search results](https://zenodo.org/search?page=1&size=20&q=sourmash&sort=mostrecent) - [ ] `pip install sourmash` installs the correct version - [ ] [conda-forge sourmash-minimal-feedstock](https://github.com/conda-forge/sourmash-minimal-feedstock) has updated `sourmash-minimal` to the correct version - [ ] `mamba create -n smash-release -y sourmash` installs the correct version Optional but recommended: - [ ] PR submitted to update pyodide version - [ ] PR submitted to update spack version --- ## Release notes: - Bump histogram from 0.9.1 to 0.10.0 (#3109) - Bump getrandom from 0.2.12 to 0.2.14 (#3108) - MRG: add pyopensci review badge (#3105) - Bump enum_dispatch from 0.3.12 to 0.3.13 (#3102) - Bump serde_json from 1.0.114 to 1.0.115 (#3101) - Update pytest-cov requirement from <5.0,>=4 to >=4,<6.0 (#3097) - Bump rayon from 1.9.0 to 1.10.0 (#3098) - Implement file parsing for webassembly (#3047)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1577 (comment)
This PR implements
ReadforFilein browsers, which allows usingniffler+needletailto parse FASTA/Q,.gzcompressed or not, in browsers.I also added error handling, so the browser can print nicer error messages instead of something cryptic to
console.log.