Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] clear to eol in notify(...) and error(...) #351

Merged
merged 9 commits into from
Mar 12, 2018
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Oct 2, 2017

Fixes #344 by using magic vt100 commands to clear to EOL before printing.

Also cleans up sourmash compute --merge output for multiple signatures - fixes #352.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Oct 2, 2017

Codecov Report

Merging #351 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   90.29%   90.49%   +0.19%     
==========================================
  Files          33       33              
  Lines        4885     4891       +6     
  Branches       36       36              
==========================================
+ Hits         4411     4426      +15     
+ Misses        473      464       -9     
  Partials        1        1
Impacted Files Coverage Δ
sourmash/commands.py 91.21% <100%> (+0.03%) ⬆️
sourmash/logging.py 100% <100%> (ø) ⬆️
sourmash/sbt_storage.py 95.5% <0%> (-1.09%) ⬇️
sourmash/lca/lca_utils.py 94.47% <0%> (+1%) ⬆️
sourmash/signature_json.py 95.51% <0%> (+1.92%) ⬆️
tests/test_signature_json.py 100% <0%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edb7c7...48908e0. Read the comment docs.

@ctb ctb changed the title clear to eol in notify(...) and error(...) [WIP] clear to eol in notify(...) and error(...) Oct 2, 2017
@ctb ctb changed the title [WIP] clear to eol in notify(...) and error(...) [MRG] clear to eol in notify(...) and error(...) Mar 11, 2018
@ctb
Copy link
Contributor Author

ctb commented Mar 11, 2018

Ready for review!

@luizirber luizirber merged commit 4572f5c into master Mar 12, 2018
@luizirber luizirber deleted the fix/clear_to_eol branch March 12, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants