Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNA --> nucleotide and protein #473

Merged
merged 1 commit into from
May 15, 2018
Merged

DNA --> nucleotide and protein #473

merged 1 commit into from
May 15, 2018

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented May 15, 2018

When I first saw sourmash I thought I couldn't use it because I had RNA not DNA. And now I see you do protein signatures too! So I propose this change so others don't get deterred either.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

When I first saw sourmash I thought I couldn't use it because I had RNA not DNA. And now I see you do protein signatures too! So I propose this change so others don't get deterred either.
@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files          33       33           
  Lines        4892     4892           
  Branches       36       36           
=======================================
  Hits         4428     4428           
  Misses        463      463           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4144584...662692e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants