Hyperlink DOIs to preferred resolver #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 25 25
Lines 3543 3543
Branches 37 37
=======================================
Hits 3136 3136
Misses 407 407Continue to review full report at Codecov.
|
luizirber
approved these changes
Oct 27, 2018
|
Thanks @katrinleinweber! |
|
You're welcome, and thanks for merging :-) |
ctb
added a commit
that referenced
this pull request
Dec 12, 2018
* a trial refactoring of the lca db * save and load seem to basically work * got search & gather on LCA working in new framework * allow key error * keep identities with no lineage assigment * add multigather * Hyperlink DOIs to preferred resolver (#562) * fix divide by zero issue in MinHash.contained_by (#572) * fix divide by zero issue in contained_by * remove unused lineages and identifiers * update report output * majority of lca tests passing now! * fix gather? * ...all tests pass?
bluegenes
pushed a commit
that referenced
this pull request
Mar 9, 2023
I only ran a script to generate: #562 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as dib-lab/khmer#1881 ;-)
make testDid it pass the tests?make coverageIs the new code covered?Did it change the command-line interface? Only additions are allowedwithout a major version increment. Changing file formats also requires a
major version number increment.
Was a spellchecker run on the source code and documentation afterchanges were made?