Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix two temporary files output locations in tests #989

Merged
merged 1 commit into from
May 13, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented May 13, 2020

There are two tests generating files outside the temporary directory...

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@luizirber
Copy link
Member Author

Ready for review and merge @ctb

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #989 into master will increase coverage by 12.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #989       +/-   ##
===========================================
+ Coverage   80.05%   92.23%   +12.17%     
===========================================
  Files          97       72       -25     
  Lines        7887     5368     -2519     
===========================================
- Hits         6314     4951     -1363     
+ Misses       1573      417     -1156     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
src/core/src/wasm.rs
src/core/src/ffi/utils.rs
src/core/src/signature.rs
src/core/src/sketch/ukhs.rs
src/core/src/ffi/mod.rs
src/core/src/ffi/signature.rs
src/core/src/sketch/nodegraph.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/sketch/minhash.rs
src/core/src/index/storage.rs
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b7884...9cbddd4. Read the comment docs.

@luizirber luizirber merged commit ce48fe6 into master May 13, 2020
@luizirber luizirber deleted the test_fix_tempfile branch May 13, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants