Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirm column names match sourmash where they are in common #46

Closed
ctb opened this issue Aug 24, 2023 · 1 comment · Fixed by #50
Closed

confirm column names match sourmash where they are in common #46

ctb opened this issue Aug 24, 2023 · 1 comment · Fixed by #50

Comments

@ctb
Copy link
Collaborator

ctb commented Aug 24, 2023

with #45, the md5 column names should be the same as sourmash prefetch which I think is the future of sourmash. see sourmash-bio/sourmash#1555. But, you know, verify.
@ctb
Copy link
Collaborator Author

ctb commented Aug 24, 2023

I guess pyo3_branchwater should provide at least a strict subset of the column names.

maybe just encode that in tests... 😁

@ctb ctb mentioned this issue Aug 24, 2023
Merged
@ctb ctb closed this as completed in #50 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: adjust column names to match sourmash prefetch sourmash-bio/sourmash_plugin_branchwater
1 participant
@ctb