Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to allow to install mod_fastcgi from source (even on Debian familly) #293

Merged
merged 5 commits into from
Feb 17, 2015

Conversation

jujugrrr
Copy link
Contributor

You might need to install mod_fastcgi from source, even if you use Debian and have the mod_fastcgi package.
The PR is adding unit and integration tests for mod_fastcgi as well

default['apache']['lib_dir'] = '/usr/lib/apache2'
default['apache']['libexec_dir'] = "#{node['apache']['lib_dir']}/modules"
default['apache']['lib_dir'] = '/usr/lib/apache2'
default['apache']['libdev_dir'] = '/usr/share/apache2'

This comment was marked as outdated.

This comment was marked as outdated.

@@ -18,3 +18,4 @@
#

default['apache']['mod_fastcgi']['download_url'] = 'http://www.fastcgi.com/dist/mod_fastcgi-current.tar.gz'
default['apache']['mod_fastcgi']['force_source'] = false

This comment was marked as outdated.

@svanzoest
Copy link
Contributor

Thanks for your work on this.
I haven't gotten around to run this yet, but do your updated tests test both the package and source installs for mod_fastcgi?

@jujugrrr
Copy link
Contributor Author

I haven't gotten around to run this yet, but do your updated tests test both the package and source installs for mod_fastcgi?

Hi @svanzoest . It does in chefspec but not in kitchen as I didn't want to create a new suite with a different attributes. https://github.com/jujugrrr/apache2/blob/mod_fastcgi_source_flag/spec/modules/mod_fastcgi_spec.rb#L61-L70

I'm adding your other suggestions.

@jujugrrr
Copy link
Contributor Author

Thanks for your work on this.

Np 😉

@svanzoest svanzoest self-assigned this Nov 20, 2014
@svanzoest
Copy link
Contributor

I am just checking in on this as I would like to pull this into master for the next release. Let me know if I can help.

@jujugrrr
Copy link
Contributor Author

jujugrrr commented Dec 2, 2014

I lost track with this one, do you just need me to fix the merge conflict? or do you need me to add something else?

cheers

@svanzoest svanzoest merged commit e5e00f6 into sous-chefs:master Feb 17, 2015
@svanzoest
Copy link
Contributor

Merged. Thanks!

svanzoest added a commit that referenced this pull request Feb 17, 2015
@jujugrrr
Copy link
Contributor Author

@svanzoest :-)

@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot unassigned svanzoest Jul 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants