Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test in Travis with Chef-DK and a Rakefile #454

Merged
merged 5 commits into from
Nov 11, 2016
Merged

Test in Travis with Chef-DK and a Rakefile #454

merged 5 commits into from
Nov 11, 2016

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Nov 11, 2016

Using ChefDK avoids having to match Ruby releases and Gem releases to match Chef tooling.

@tas50
Disable foodcritic rules with a .foodcritic file
384a5d0 
This way they're disabled no matter where things are run

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Switch to cookstyle
edbef59 
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Test in ChefDK and avoid double testing
493e503 
Avoid testing branches and PRs on a single commit

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Add a rakefile for 1 command testing
596d0f7 
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Disable the extra space cop
c96a45f 
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Copy link
Contributor Author

tas50 commented Nov 11, 2016

This is going to fail until the extra cops are removed. That fix is in #453

svanzoest
svanzoest reviewed Nov 11, 2016
View reviewed changes
.rubocop.yml
@@ -24,3 +24,5 @@ TrivialAccessors:
ExactNameMatch: true
Style/RegexpLiteral:
Enabled: false
Style/ExtraSpacing:
Enabled: false

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

@tas50 tas50 mentioned this pull request Nov 11, 2016
Closed
svanzoest
svanzoest reviewed Nov 11, 2016
View reviewed changes
Copy link
Contributor

@svanzoest svanzoest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add another script to do the same thing, when we already have guard?

svanzoest
svanzoest reviewed Nov 11, 2016
View reviewed changes
Gemfile
@@ -8,7 +8,7 @@ gem 'berkshelf', '~> 5.1', '>= 5.1.0'

group :unit do
gem 'foodcritic', '~> 8.1', '>= 8.1.0'
gem 'rubocop', '~> 0.45', '>= 0.45.0'
gem 'cookstyle'

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

@zuazo
Copy link

zuazo commented Nov 11, 2016 •
edited
Loading

Travis/RuboCop error (it seems easy to fix):

definitions/apache_module.rb:20:78: W: Unnecessary disabling of Metrics/BlockLength (did you mean Metrics/BlockNesting?).
define :apache_module, :enable => true, :conf => false, :restart => false do # rubocop:disable Metrics/BlockLength
                                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
recipes/mod_php.rb:28:30: W: Unnecessary disabling of Style/MultilineIfModifier (did you mean Style/MultilineIfThen?).
case node['platform_family'] # rubocop:disable Style/MultilineIfModifier
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@svanzoest
Copy link
Contributor

svanzoest commented Nov 11, 2016 via email

svanzoest
svanzoest reviewed Nov 11, 2016
View reviewed changes
.travis.yml
- bundle exec berks
- eval "$(/opt/chefdk/bin/chef shell-init bash)"
# We have to install chef-sugar for ChefSpec
- /opt/chefdk/embedded/bin/chef gem install chef-sugar

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

@svanzoest svanzoest merged commit a74114e into master Nov 11, 2016
@svanzoest svanzoest deleted the travis branch November 11, 2016 19:33
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@svanzoest svanzoest svanzoest left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tas50 @zuazo @svanzoest