Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverspec to InSpec migration #460

Merged
merged 8 commits into from
Feb 12, 2017
Merged

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented Jan 4, 2017

Description

This PR migrates the existing integration tests to InSpec. It does this with minimal changes. Also it uses the same tests for default and prefork suite.

Check List

screen shot 2017-01-04 at 2 05 10 pm

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
Copy link
Contributor Author

Anything I can do to get this merged?

@svanzoest
Copy link
Contributor

svanzoest commented Jan 5, 2017 via email

@chris-rock
Copy link
Contributor Author

ChefSpec is executed in travis: https://travis-ci.org/sous-chefs/apache2/builds/188876022#L222 I fixed the location there as well.

@chris-rock
Copy link
Contributor Author

@svanzoest Any updates on that?

@damacus
Copy link
Member

damacus commented Feb 4, 2017

The only difference (apart from the verifier) is the new error from the default-debian-86 verifier.

According to inspec apache2 isn't running. But:

● apache2.service - LSB: Apache2 web server
   Loaded: loaded (/etc/init.d/apache2)
  Drop-In: /lib/systemd/system/apache2.service.d
           └─forking.conf
   Active: active (running) since Sat 2017-02-04 19:47:14 UTC; 1min 26s ago
  Process: 3728 ExecStart=/etc/init.d/apache2 start (code=exited, status=0/SUCCESS)
   CGroup: /system.slice/apache2.service
           ├─3744 /usr/sbin/apache2 -k start
           ├─3747 /usr/sbin/apache2 -k start
           ├─3749 /usr/sbin/apache2 -k start
           ├─3750 /usr/sbin/apache2 -k start
           └─3751 /usr/sbin/apache2 -k start

Feb 04 19:47:13 working.computers.biz systemd[1]: Starting LSB: Apache2 web server...
Feb 04 19:47:14 working.computers.biz apache2[3728]: Starting web server: apache2.
Feb 04 19:47:14 working.computers.biz systemd[1]: Started LSB: Apache2 web server.

Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the apache2 test on default-debian-86

@tas50
Copy link
Contributor

tas50 commented Feb 12, 2017

We have a failure on Debian 8.6, but that's an Inspec issue and there's not much we can do to work around that at the moment. There's an issue for it upstream.

@tas50 tas50 merged commit fb44798 into sous-chefs:master Feb 12, 2017
@chris-rock
Copy link
Contributor Author

Related to inspec/inspec#931

@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants