Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of the FIPS endpoint for the S3_file resource and update the create_aws_interface method to support this functionality #490

Merged
merged 6 commits into from
Oct 27, 2024

Conversation

achinthagunasekara
Copy link
Contributor

@achinthagunasekara achinthagunasekara commented Oct 11, 2024

Description

Enable the use of the FIPS endpoint for the S3_file resource and update the create_aws_interface method to support this functionality

Issues Resolved

Ability to download S3 files using the FIPS endpoints

Testing

Testing with use_fips_endpoint set to true

Used the cookbook to download a file with these changes and use_fips_endpoint set to true

[2024-10-14T16:32:00-07:00] DEBUG: Initializing the S3 Object for bucket: XXXXX path: some/path/sandbox/file
[2024-10-14T16:32:00-07:00] DEBUG: Initializing the S3 Client
[2024-10-14T16:32:00-07:00] DEBUG: Using local credential chain
[2024-10-14T16:32:00-07:00] DEBUG: Initializing interface with client interface options: {:region=>"us-east-1", :http_proxy=>"", :use_fips_endpoint=>true}
[2024-10-14T16:32:00-07:00] INFO: Remote and local files do not match, running create operation.
[2024-10-14T16:32:00-07:00] DEBUG: Initializing the S3 Object for bucket: XXXXX path: some/path/sandbox/file
[2024-10-14T16:32:00-07:00] DEBUG: Using S3 URL https://XXXXX.s3-fips.amazonaws.com/some/path/sandbox/file?.......

Testing with use_fips_endpoint not set (default = false)

[2024-10-14T16:41:56-07:00] DEBUG: Initializing the S3 Object for bucket: XXXXX path: some/path/sandbox/file
[2024-10-14T16:41:56-07:00] DEBUG: Initializing the S3 Client
[2024-10-14T16:41:56-07:00] DEBUG: Using local credential chain
[2024-10-14T16:41:56-07:00] DEBUG: Initializing interface with client interface options: {:region=>"us-east-1", :http_proxy=>"", :use_fips_endpoint=>false}
[2024-10-14T16:41:56-07:00] INFO: Remote and local files do not match, running create operation.
[2024-10-14T16:41:56-07:00] DEBUG: Initializing the S3 Object for bucket: XXXXX path: some/path/sandbox/file
[2024-10-14T16:41:56-07:00] DEBUG: Using S3 URL https://XXXXX.s3.amazonaws.com/some/path/sandbox/file?.......

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Archie Gunasekara added 2 commits October 11, 2024 15:21
@achinthagunasekara achinthagunasekara requested a review from a team as a code owner October 11, 2024 04:30
@achinthagunasekara achinthagunasekara changed the title allow using FIPS endpoint for S3_file resource and update create_aws_interface to support it Enable the use of the FIPS endpoint for the S3_file resource and update the create_aws_interface method to support this functionality Oct 11, 2024
libraries/ec2.rb Outdated Show resolved Hide resolved
@Stromweld Stromweld added the Release: Minor Release to Chef Supermarket as a minor release when merged label Oct 14, 2024
Co-authored-by: Corey Hemminger <hemminger@hotmail.com>
Archie Gunasekara and others added 2 commits October 15, 2024 10:33
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth merged commit 6b6e856 into sous-chefs:main Oct 27, 2024
9 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 9.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants