Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add none as an option to service_manager to allow using the system defaults #1283

Merged
merged 6 commits into from
Aug 3, 2024

Conversation

ramereth
Copy link
Contributor

@ramereth ramereth commented Aug 1, 2024

This is needed if you're trying to use the system packages and not the upstream
repository. This is useful for non-standard CPU architectures which might not
have upstream support.

Signed-off-by: Lance Albertson lance@osuosl.org

Description

Describe what this change achieves

Issues Resolved

List any existing issues this PR resolves

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

…faults

This is needed if you're trying to use the system packages and not the upstream
repository. This is useful for non-standard CPU architectures which might not
have upstream support.

Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth requested a review from a team as a code owner August 1, 2024 00:11
@ramereth ramereth added Release: Patch Release to Chef Supermarket as a version patch when merged Release: Minor Release to Chef Supermarket as a minor release when merged and removed Release: Patch Release to Chef Supermarket as a version patch when merged labels Aug 1, 2024
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Copy link
Contributor Author

ramereth commented Aug 3, 2024

@bmhughes can you please take a look at this? I'd like to get this merged soon

Stromweld
Stromweld previously approved these changes Aug 3, 2024
Copy link
Contributor

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kitchen.yml Outdated Show resolved Hide resolved
Co-authored-by: Corey Hemminger <hemminger@hotmail.com>
@ramereth ramereth merged commit ed04d64 into main Aug 3, 2024
53 checks passed
@ramereth ramereth deleted the service-manager-none branch August 3, 2024 17:11
@kitchen-porter
Copy link
Contributor

Released as: 11.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants