Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to define recycling schedule #397

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

jakauppila
Copy link
Contributor

@jakauppila jakauppila commented Oct 15, 2017

Description

Adds the ability to define multiple recycle times on an app pool.

I would have preferred to call the property periodic_restart_schedule but to maintain backwards compatibility continued to use recycle_at_time.

The property accepts both a string and array which are coerced into an array when being used.

Issues Resolved

#194

Check List

Signed-off-by: Jared Kauppila <Jared@Kauppi.la>
@EasyAsABC123
Copy link
Contributor

Looks good :+1 I'd say for the first release we could simply add the new property you want to use and then have the old property map to it.

Then we will do another release for a major change and remove it as it will be deprecated.

Other than that this looks good, I'll approve if no response by Monday

@EasyAsABC123 EasyAsABC123 merged commit fd5873c into sous-chefs:master Oct 16, 2017
@jakauppila
Copy link
Contributor Author

You're quicker than me! I can get those other changes in prior to cutting another release; is there a way to define recycle_at_time as an alias? I'm not seeing it in the custom resource documentation.

@iennae
Copy link
Contributor

iennae commented Oct 16, 2017

@jakauppila it's a rubyism.

Format

alias_method :ORIGINALNAME, :NEWNAME

You can see an example of it done here https://github.com/chef-cookbooks/chef_handler/blob/master/resources/default.rb#L28 with supports being the original name that has been aliased to new name type to help with the confusion around supports as a property.

@jakauppila
Copy link
Contributor Author

Thanks @iennae!

Should that be added to the custom resource documentation? Seems like it's a common enough use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants