fix bug with setting no_managed_code #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasyAsABC123
added
Priority: Medium
Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>
tas50
reviewed
Jan 2, 2018
| @@ -269,8 +269,12 @@ def configure | |||
| end | |||
|
|
|||
| if new_resource.no_managed_code | |||
| converge_if_changed :runtime_version do | |||
| Chef::Log.warn("ran into no managed runtime #{new_resource.runtime_version} | #{current_resource.runtime_version}") | |||
There was a problem hiding this comment.
What's your intention with #{new_resource.runtime_version} | #{current_resource.runtime_version}" here?
There was a problem hiding this comment.
I honestly don't know why i did the above, it looks like i hit a bug with Chef converge_if_changed
|
This needs a rebase before we can merge it in. |
tas50
added
Status: Pending Contributor Response
and removed
Status: Maintainer Review Needed
labels
|
was destroyed and moved to #434 |
tas50
added
Triage: Needs Information
and removed
Status: Pending Contributor Response
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by jmschu02@gmail.com
Description
Fixes a bug in
iis_poolthat causes an issue with resetting to no_managed_code runtime versionsIssues Resolved
#395
Check List