-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cli user and password options #717
Conversation
Hey @ddegoede Can you add a changelog entry for me so we can look to get this shipped? Thanks! |
Hi @xorima will do so tomorrow. Thanks for checking this PR. |
This adds a specified user to use for basic authentication for the jenkins-cli using a username and password, where the password is a token Signed-off-by: Daan de Goede <ddegoede@schubergphilis.com>
Hi @xorima, I added/amended the changelog, hope you do not mind me taking credit for the groovy indentation fix, merged earlier. Also rebased and fixed the spec test. |
Released as: 8.1.0 |
Yes please, I'm not a Jenkins expert by any means btw, I just merge stuff (releases are automated here) Would you be willing to help maintain this cookbook as it sounds like you have a lot more knowledge than I do on Jenkins? |
I'm happy to help review changes as well. Open Robotics is using this jenkins cookbook for several different large Jenkins instances and while our job configurations are all done outside of chef cutting away at the manual steps in bootstrapping and updating our global Jenkins configuration is a situation we're actively trying to improve. |
For anyone willing to help maintain drop by #sous-chefs on chef community slack and we can walk you through the process of joining the org :) |
Description
This adds a specified user to use for basic authentication for the jenkins-cli
using a username and password, where the password is a token
Signed-off-by: Daan de Goede ddegoede@schubergphilis.com
Issues Resolved
This partially fixes #599, is enables http protocol if a username and password is given.
Check List