Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cli user and password options #717

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Adding cli user and password options #717

merged 3 commits into from
Dec 1, 2020

Conversation

ddegoede
Copy link
Contributor

@ddegoede ddegoede commented Apr 5, 2019

Description

This adds a specified user to use for basic authentication for the jenkins-cli
using a username and password, where the password is a token

Signed-off-by: Daan de Goede ddegoede@schubergphilis.com

Issues Resolved

This partially fixes #599, is enables http protocol if a username and password is given.

Check List

@xorima xorima added the Release: Minor Release to Chef Supermarket as a minor release when merged label Nov 20, 2020
@xorima
Copy link
Contributor

xorima commented Nov 20, 2020

Hey @ddegoede

Can you add a changelog entry for me so we can look to get this shipped?

Thanks!

@ddegoede
Copy link
Contributor Author

Hi @xorima will do so tomorrow. Thanks for checking this PR.

This adds a specified user to use for basic authentication for the jenkins-cli
using a username and password, where the password is a token

Signed-off-by: Daan de Goede <ddegoede@schubergphilis.com>
@ddegoede
Copy link
Contributor Author

ddegoede commented Dec 1, 2020

Hi @xorima, I added/amended the changelog, hope you do not mind me taking credit for the groovy indentation fix, merged earlier. Also rebased and fixed the spec test.

@xorima xorima merged commit 794e1d8 into sous-chefs:master Dec 1, 2020
@kitchen-porter
Copy link
Contributor

Released as: 8.1.0

@ddegoede ddegoede deleted the cli-user branch December 1, 2020 09:09
@ddegoede
Copy link
Contributor Author

ddegoede commented Dec 1, 2020

@xorima that was quick 👍 I was just reading this page about the cli and authentication, and saw that it is actually the apitoken and not a password, shall I create a next MR to reflect this? And also add the option to use file based authentication for the -auth option?

@xorima
Copy link
Contributor

xorima commented Dec 1, 2020

@xorima that was quick 👍 I was just reading this page about the cli and authentication, and saw that it is actually the apitoken and not a password, shall I create a next MR to reflect this? And also add the option to use file based authentication for the -auth option?

Yes please, I'm not a Jenkins expert by any means btw, I just merge stuff (releases are automated here)

Would you be willing to help maintain this cookbook as it sounds like you have a lot more knowledge than I do on Jenkins?

@nuclearsandwich
Copy link
Contributor

Would you be willing to help maintain this cookbook as it sounds like you have a lot more knowledge than I do on Jenkins?

I'm happy to help review changes as well. Open Robotics is using this jenkins cookbook for several different large Jenkins instances and while our job configurations are all done outside of chef cutting away at the manual steps in bootstrapping and updating our global Jenkins configuration is a situation we're actively trying to improve.

@xorima
Copy link
Contributor

xorima commented Dec 1, 2020

For anyone willing to help maintain drop by #sous-chefs on chef community slack and we can walk you through the process of joining the org :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jenkins 2.54 new cli options: -http, -ssh, -remoting to jenkins_script resource
4 participants