Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in 'creates' for file-existence check #112

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

seren
Copy link

@seren seren commented Jul 28, 2017

Description

This just replaces a ruby file-existence check with a chef 'creates' check. Either should prevent the block from executing if the file exists, but this way is cleaner and more chefy.

Check List

  • All relevant tests pass. There are some unrelated failures (openssl crl tests, procps service failure, etc).

Copy link
Contributor

@flaccid flaccid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flaccid flaccid self-assigned this Jul 30, 2017
@flaccid flaccid added this to the v3 milestone Jul 30, 2017
@flaccid flaccid merged commit a48a17e into sous-chefs:master Jul 30, 2017
@lock
Copy link

lock bot commented Jul 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants