Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [File] Screen reader is not announcing the available Shortcut key information with control. #93

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: [File] Screen reader is not announcing the available Shortcut key information with control. #93

wants to merge 4 commits into from

Conversation

FedericoBernal
Copy link

@FedericoBernal FedericoBernal commented Dec 9, 2021 •
edited
Loading

Description

As reported by the issue "Screen reader is not announcing the available Shortcut key information with control" was present under File menu section.

Changes made

We added the subtext to be read inside the aria-label.

Testing

image (99)

@FedericoBernal FedericoBernal self-assigned this Dec 9, 2021
luislera
luislera requested changes Dec 10, 2021
View reviewed changes
Copy link

@luislera luislera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, check that the test cases included in the menuItem.spec.tsx pass without any errors:

imagen

packages/sdk/ui-react/src/widget/menu/menuItem.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luislera luislera Awaiting requested review from luislera

Assignees

@FedericoBernal FedericoBernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedericoBernal @luislera