Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Wrapper: Use Case API Initiative (Ongoing) #182

Open
2 of 18 tasks
Tracked by #177
richardtreier opened this issue Mar 15, 2023 · 4 comments
Open
2 of 18 tasks
Tracked by #177

API Wrapper: Use Case API Initiative (Ongoing) #182

richardtreier opened this issue Mar 15, 2023 · 4 comments
Assignees
Labels
component/api-wrapper Impacts the API-wrapper API. kind/epic Epic which groups several user stories status/blocked/needs-product requires input from product owner

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Mar 15, 2023

Epic

Description

With our EDC API Wrapper and EDC API Clients underway the goal is to develop an API for Use Case Application developers that can contain a simplified EDC workflow, and more stable API endpoints than our UI endpoints. This is required because our API Wrapper UI API is both tightly coupled to the UI scope and subject to change over time depending on UI needs.

Requirements

Work Breakdown

  • Implement simplified workflow
    • createDataOffer
    • updateDataOffer
    • negotiateContract
    • initiateTransfer
    • transfers
    • catalog
  • Decide which other Management API endpoints to wrap
    • Vault Access
    • getContracts
    • getAssets
    • getAssetById
    • getContractById
    • getTransferById
  • HttpProxy in Use Case API Wrapper #958

Acceptance criteria and must have scope

  • Simplified Workflow working.
  • Transferring data is possible.
@richardtreier richardtreier changed the title EDC API Clients for Use Cases EDC API for Use Cases (EDC API Wrapper + EDC API Clients) Mar 15, 2023
@richardtreier richardtreier changed the title EDC API for Use Cases (EDC API Wrapper + EDC API Clients) EDC Use Case API Client Mar 15, 2023
@richardtreier richardtreier changed the title EDC Use Case API Client Generic Use Case API Wrapper and Client Mar 15, 2023
@tmberthold tmberthold added the component/api-wrapper Impacts the API-wrapper API. label Mar 27, 2023
@SebastianOpriel SebastianOpriel added kind/epic Epic which groups several user stories area/api-wrapper and removed epic component/api-wrapper Impacts the API-wrapper API. labels Apr 18, 2023
@richardtreier
Copy link
Collaborator Author

richardtreier commented May 16, 2023

4. Copy all necessary model classes to the Wrapper and add swagger annotations.

To summarize from friday: This is what it will most likely be. We will decide the own data amount to return per endpoint. This might be less than the Management API returns, or more. This makes it so that we can also change the object's structure, e.g. for policies.

We do not need to copy all the classes, but can decide on a per-endpoint basis what the right thing to return is.

For cases with polymorphisms, such as the EDC Expression class we need to provide sum types, so we A) have a decided and clear cut scope we support and B) they can work in the generated clients, as overriding JSON in Java is not easy.

@M-Fitzke M-Fitzke mentioned this issue Aug 22, 2023
10 tasks
@richardtreier richardtreier removed their assignment Jan 8, 2024
@AbdullahMuk AbdullahMuk added component/api-wrapper Impacts the API-wrapper API. status/blocked/needs-info requires more information in order to be completed labels Mar 13, 2024
@AbdullahMuk
Copy link
Collaborator

As I understand from the current status of the API Wrapper, we have implemented simplified workflow already. Assuming my understanding is correct, we should evaluate what remains to be completed and define the solution proposal accordingly.

Target for evaluation is: Sprint 43

@AbdullahMuk AbdullahMuk changed the title Generic Use Case API Wrapper and Client [API Wrapper] Generic Use Case API Wrapper and Client Mar 13, 2024
@AbdullahMuk AbdullahMuk added the clean-backlog requires backlog cleaning label May 2, 2024
ununhexium pushed a commit that referenced this issue May 2, 2024
Bumps io.swagger.core.v3:swagger-jaxrs2-jakarta from 2.2.14 to 2.2.15.

---
updated-dependencies:
- dependency-name: io.swagger.core.v3:swagger-jaxrs2-jakarta
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@richardtreier richardtreier changed the title [API Wrapper] Generic Use Case API Wrapper and Client API Wrapper: Use Case API Initiative (Ongoing) May 29, 2024
@richardtreier richardtreier added status/blocked/needs-product requires input from product owner and removed clean-backlog requires backlog cleaning status/blocked/needs-info requires more information in order to be completed labels May 29, 2024
@sovity sovity deleted a comment May 29, 2024
@richardtreier
Copy link
Collaborator Author

As I understand from the current status of the API Wrapper, we have implemented simplified workflow already. Assuming my understanding is correct, we should evaluate what remains to be completed and define the solution proposal accordingly.

Target for evaluation is: Sprint 43

No we have not. The idea is to offer a simplified "createDataOffer", "deleteDataOffer", "listDataOffers" as single API calls

@SebastianOpriel
Copy link
Member

@richardtreier what is the status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api-wrapper Impacts the API-wrapper API. kind/epic Epic which groups several user stories status/blocked/needs-product requires input from product owner
Projects
None yet
Development

No branches or pull requests

5 participants