Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only return Datasets with valid Offers #1066

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: Only return Datasets with valid Offers #1066

merged 2 commits into from
Oct 17, 2024

Conversation

efiege
Copy link
Contributor

@efiege efiege commented Oct 17, 2024 •
edited
Loading

Closes #1065

Checklist
Preview Give feedback

@efiege efiege linked an issue Oct 17, 2024 that may be closed by this pull request
Only Return Datasets with valid Offers #1065
Closed
richardtreier
richardtreier approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ununhexium
ununhexium approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@efiege efiege merged commit e7f8a57 into main Oct 17, 2024
18 checks passed
@efiege efiege deleted the 1065-only-return-datasets-with-valid-offers branch October 17, 2024 11:48
kamilczaja pushed a commit that referenced this pull request Dec 13, 2024
@efiege @kamilczaja
fix: Only return Datasets with valid Offers (#1066)
83a999a 
(cherry picked from commit e7f8a57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier approved these changes

@ununhexium ununhexium ununhexium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only Return Datasets with valid Offers
3 participants
@efiege @ununhexium @richardtreier