Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add contract cancellation initiator to the API #992

Merged
merged 6 commits into from
Jul 9, 2024
Merged

feat: Add contract cancellation initiator to the API #992

merged 6 commits into from
Jul 9, 2024

Conversation

ununhexium
Copy link
Collaborator

@ununhexium ununhexium commented Jul 9, 2024 •
edited
Loading

Checklist
Beta Give feedback

ununhexium
ununhexium commented Jul 9, 2024
View reviewed changes
Copy link
Collaborator Author

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review done.

...per-api/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractAgreementPageQuery.java Outdated Show resolved Hide resolved
...r-api/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractTerminationInitiator.java Outdated Show resolved Hide resolved
...r-api/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractTerminationInitiator.java Outdated Show resolved Hide resolved
docs/api/sovity-edc-api-wrapper.yaml Outdated Show resolved Hide resolved
richardtreier
richardtreier requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one place which does not belong in the PR

...vity-messenger/src/test/java/de/sovity/edc/extension/messenger/impl/SovityMessengerTest.java Outdated Show resolved Hide resolved
richardtreier
richardtreier approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardtreier richardtreier merged commit e2e41d6 into main Jul 9, 2024
16 checks passed
@richardtreier richardtreier deleted the amend-api-with-initiator branch July 9, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtreier richardtreier richardtreier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ununhexium @richardtreier