Skip to content

Commit

Permalink
unit tests and fixes from testing
Browse files Browse the repository at this point in the history
  • Loading branch information
@aprakash-sovrn
aprakash-sovrn committed Oct 8, 2019
1 parent 3c84900 commit ef405a2
Show file tree
Hide file tree
Showing 2 changed files with 143 additions and 50 deletions.
65 changes: 39 additions & 26 deletions modules/sovrnBidAdapter.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,19 @@ export const spec = {
let sovrnImps = [];
let iv;
let schain;
let digitrust;

utils._each(bidReqs, function (bid) {
if(bid.schain) {
if (!digitrust) {
const bidRequestDigitrust = utils.deepAccess(bid, 'userId.digitrustid.data');
if (bidRequestDigitrust && (!bidRequestDigitrust.privacy || !bidRequestDigitrust.privacy.optout)) {
digitrust = {
id: bidRequestDigitrust.id,
keyv: bidRequestDigitrust.keyv
}
}
}
if (bid.schain) {
schain = schain || bid.schain;
}
iv = iv || utils.getBidIdParameter('iv', bid.params);
Expand All @@ -56,7 +67,7 @@ export const spec = {
}
};

if(schain) {
if (schain) {
sovrnBidReq.source = {
ext: {
schain
Expand All @@ -75,13 +86,12 @@ export const spec = {
}};
}

const bidRequestDigitrust = utils.deepAccess(bidRequest, 'userId.digitrustid.data');
if (bidRequestDigitrust && !bidRequestDigitrust.privacy.optout) {
if (digitrust) {
sovrnBidReq.user = sovrnBidReq.user || {};
sovrnBidReq.user.ext = sovrnBidReq.user.ext || {}
sovrnBidReq.user.ext.digitrust = {
id: bidRequestDigitrust.id,
keyv: bidRequestDigitrust.keyv
id: digitrust.id,
keyv: digitrust.keyv
}
}

Expand Down Expand Up @@ -138,28 +148,31 @@ export const spec = {
getUserSyncs: function(syncOptions, serverResponses, gdprConsent) {
try {
let tracks = []
if (serverResponses && serverResponses.length !== 0 && syncOptions.iframeEnabled) {
let iidArr = serverResponses.filter(resp => resp.body && resp.body.ext && resp.body.ext.iid)
.map(resp => resp.body.ext.iid);
let consentString = '';
if (gdprConsent && gdprConsent.gdprApplies && typeof gdprConsent.consentString === 'string') {
consentString = gdprConsent.consentString
}
if (iidArr[0]) {
tracks.push({
type: 'iframe',
url: '//ap.lijit.com/beacon?informer=' + iidArr[0] + '&gdpr_consent=' + consentString,
});
if (serverResponses && serverResponses.length !== 0) {
if (syncOptions.iframeEnabled) {
let iidArr = serverResponses.filter(resp => resp.body && resp.body.ext && resp.body.ext.iid)
.map(resp => resp.body.ext.iid);
let consentString = '';
if (gdprConsent && gdprConsent.gdprApplies && typeof gdprConsent.consentString === 'string') {
consentString = gdprConsent.consentString
}
if (iidArr[0]) {
tracks.push({
type: 'iframe',
url: '//ap.lijit.com/beacon?informer=' + iidArr[0] + '&gdpr_consent=' + consentString,
});
}
}
}
if(syncOptions.pixelEnabled) {
if (serverResponses && serverResponses.length !== 0) {

if (syncOptions.pixelEnabled) {
serverResponses.filter(resp => resp.body && resp.body.ext && resp.body.ext.sync && resp.body.ext.sync.pixels)
.map(resp => resp.body.ext.sync.pixels.url)
.forEach(url => tracks.push({ type: 'image', url}))
}
if (errorpxls.length) {
tracks = tracks.concat(errorpxls)
.flatMap(resp => resp.body.ext.sync.pixels)
.map(pixel => pixel.url)
.forEach(url => tracks.push({ type: 'image', url }))

if (errorpxls.length) {
tracks = tracks.concat(errorpxls)
}
}
}

Expand Down
128 changes: 104 additions & 24 deletions test/spec/modules/sovrnBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { expect } from 'chai';
import { spec, LogError } from 'modules/sovrnBidAdapter';
import { newBidder } from 'src/adapters/bidderFactory';
import { SSL_OP_SINGLE_ECDH_USE } from 'constants';
import {expect} from 'chai';
import {LogError, spec} from 'modules/sovrnBidAdapter';
import {newBidder} from 'src/adapters/bidderFactory';

const ENDPOINT = `//ap.lijit.com/rtb/bid?src=$$REPO_AND_VERSION$$`;

Expand Down Expand Up @@ -128,13 +127,12 @@ describe('sovrnBidAdapter', function() {
};
bidderRequest.bids = bidRequests;

const request = spec.buildRequests(bidRequests, bidderRequest);
const payload = JSON.parse(request.data);
const data = JSON.parse(spec.buildRequests(bidRequests, bidderRequest).data);

expect(payload.regs.ext.gdpr).to.exist.and.to.be.a('number');
expect(payload.regs.ext.gdpr).to.equal(1);
expect(payload.user.ext.consent).to.exist.and.to.be.a('string');
expect(payload.user.ext.consent).to.equal(consentString);
expect(data.regs.ext.gdpr).to.exist.and.to.be.a('number');
expect(data.regs.ext.gdpr).to.equal(1);
expect(data.user.ext.consent).to.exist.and.to.be.a('string');
expect(data.user.ext.consent).to.equal(consentString);
});

it('converts tagid to string', function () {
Expand All @@ -156,7 +154,68 @@ describe('sovrnBidAdapter', function() {
const request = spec.buildRequests(ivBidRequests);

expect(request.data).to.contain('"tagid":"403370"')
})
});

it('should add schain if present', () => {
const schainRequests = [{
'bidder': 'sovrn',
'params': {
'tagid': 403370
},
'adUnitCode': 'adunit-code',
'sizes': [
[300, 250],
[300, 600]
],
'bidId': '30b31c1838de1e',
'bidderRequestId': '22edbae2733bf6',
'auctionId': '1d1a030790a475',
'schain': {
'ver': '1.0',
'complete': 1,
'nodes': [
{
'asi': 'directseller.com',
'sid': '00001',
'rid': 'BidRequest1',
'hp': 1
}
]
}
}].concat(bidRequests);
const data = JSON.parse(spec.buildRequests(schainRequests).data);

expect(data.source.ext.schain.nodes.length).to.equal(1)
});

it('should add digitrust data if present', () => {
const digitrustRequests = [{
'bidder': 'sovrn',
'params': {
'tagid': 403370
},
'adUnitCode': 'adunit-code',
'sizes': [
[300, 250],
[300, 600]
],
'bidId': '30b31c1838de1e',
'bidderRequestId': '22edbae2733bf6',
'auctionId': '1d1a030790a475',
'userId': {
'digitrustid': {
'data': {
'id': 'digitrust-id-123',
'keyv': 4
}
}
}
}].concat(bidRequests);
const data = JSON.parse(spec.buildRequests(digitrustRequests).data);

expect(data.user.ext.digitrust.id).to.equal('digitrust-id-123');
expect(data.user.ext.digitrust.keyv).to.equal(4);
});
});

describe('interpretResponse', function () {
Expand Down Expand Up @@ -254,8 +313,8 @@ describe('sovrnBidAdapter', function() {
});

describe('getUserSyncs ', () => {
let syncOptions = {iframeEnabled: true, pixelEnabled: true};
let iframeDisabledSyncOptions = {iframeEnabled: false, pixelEnabled: true};
let syncOptions = { iframeEnabled: true, pixelEnabled: false };
let iframeDisabledSyncOptions = { iframeEnabled: false, pixelEnabled: false };
let serverResponse = [
{
'body': {
Expand Down Expand Up @@ -287,33 +346,54 @@ describe('sovrnBidAdapter', function() {
}
],
'ext': {
'iid': 13487408
'iid': 13487408,
sync: {
pixels: [
{
url: 'http://idprovider1.com'
},
{
url: 'http://idprovider2.com'
}
]
}
}
},
'headers': {}
}
];

it('should return if iid present on server response & iframe syncs enabled', () => {
let expectedReturnStatement = [
const expectedReturnStatement = [
{
'type': 'iframe',
'url': '//ap.lijit.com/beacon?informer=13487408&gdpr_consent=',
}
]
let returnStatement = spec.getUserSyncs(syncOptions, serverResponse);
];
const returnStatement = spec.getUserSyncs(syncOptions, serverResponse);
expect(returnStatement[0]).to.deep.equal(expectedReturnStatement[0]);
})
});

it('should not return if iid missing on server response', () => {
let returnStatement = spec.getUserSyncs(syncOptions, [])
const returnStatement = spec.getUserSyncs(syncOptions, []);
expect(returnStatement).to.be.empty;
})
});

it('should not return if iframe syncs disabled', () => {
let returnStatement = spec.getUserSyncs(iframeDisabledSyncOptions, serverResponse)
expect(returnStatement).to.be.empty
})
})
const returnStatement = spec.getUserSyncs(iframeDisabledSyncOptions, serverResponse);
expect(returnStatement).to.be.empty;
});

it('should include pixel syncs', () => {
let pixelEnabledOptions = { iframeEnabled: false, pixelEnabled: true };
const returnStatement = spec.getUserSyncs(pixelEnabledOptions, serverResponse);
console.log(returnStatement)
expect(returnStatement.length).to.equal(2);
expect(returnStatement).to.deep.include.members([{ type: 'image', url: 'http://idprovider1.com' },
{ type: 'image', url: 'http://idprovider2.com' }]);
});
});

describe('LogError', () => {
it('should build and append an error object', () => {
const thrown = {
Expand Down

0 comments on commit ef405a2

Please sign in to comment.