Skip to content

Commit

Permalink
Onetag Bid Adapter: extend mediaType support (prebid#7363)
Browse files Browse the repository at this point in the history
* add support for all mediaType fields

* fix test unit

Co-authored-by: francesco <f.orazini@onetag.com>
  • Loading branch information
2 people authored and Chris Pabst committed Jan 10, 2022
1 parent 453f26d commit f24119e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
9 changes: 3 additions & 6 deletions modules/onetagBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import find from 'core-js-pure/features/array/find.js';
import { getStorageManager } from '../src/storageManager.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { createEidsArray } from './userId/eids.js';
import { deepClone } from '../src/utils.js';

const ENDPOINT = 'https://onetag-sys.com/prebid-request';
const USER_SYNC_ENDPOINT = 'https://onetag-sys.com/usync/';
Expand Down Expand Up @@ -239,15 +240,10 @@ function requestsToBids(bidRequests) {
// Pass parameters
// Context: instream - outstream - adpod
videoObj['context'] = bidRequest.mediaTypes.video.context;
// MIME Video Types
videoObj['mimes'] = bidRequest.mediaTypes.video.mimes;
// Sizes
videoObj['playerSize'] = parseVideoSize(bidRequest);
// Other params
videoObj['protocols'] = bidRequest.mediaTypes.video.protocols;
videoObj['maxDuration'] = bidRequest.mediaTypes.video.maxduration;
videoObj['api'] = bidRequest.mediaTypes.video.api;
videoObj['playbackmethod'] = bidRequest.mediaTypes.video.playbackmethod || [];
videoObj['mediaTypeInfo'] = deepClone(bidRequest.mediaTypes.video);
videoObj['type'] = VIDEO;
return videoObj;
});
Expand All @@ -256,6 +252,7 @@ function requestsToBids(bidRequests) {
setGeneralInfo.call(bannerObj, bidRequest);
bannerObj['sizes'] = parseSizes(bidRequest);
bannerObj['type'] = BANNER;
bannerObj['mediaTypeInfo'] = deepClone(bidRequest.mediaTypes.banner);
return bannerObj;
});
return videoBidRequests.concat(bannerBidRequests);
Expand Down
7 changes: 2 additions & 5 deletions test/spec/modules/onetagBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,8 @@ describe('onetag', function () {
'pubId',
'transactionId',
'context',
'mimes',
'playerSize',
'protocols',
'maxDuration',
'api',
'playbackmethod',
'mediaTypeInfo',
'type'
);
} else if (isValid(BANNER, bid)) {
Expand All @@ -207,6 +203,7 @@ describe('onetag', function () {
'bidderRequestId',
'pubId',
'transactionId',
'mediaTypeInfo',
'sizes',
'type'
);
Expand Down

0 comments on commit f24119e

Please sign in to comment.