Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent Text type #2273

Open
gradientvera opened this issue Nov 26, 2021 · 1 comment
Open

Fluent Text type #2273

gradientvera opened this issue Nov 26, 2021 · 1 comment
Labels
Area: UI Things like game screens, menus, and windows. Difficulty: 4-Irrational Best to just wait until someone else takes the bullet tbh. Issue: Needs Refactor This issue needs a refactor to be solved. Priority: 3-Not Required Size: Very Large For especially large issues/PRs. I pity you.

Comments

@gradientvera
Copy link
Contributor

As discussed on the October 30th meeting, we should have a fluent text type to allow different locales on the server at the same time.
@gradientvera gradientvera added Priority: 3-Not Required Area: UI Things like game screens, menus, and windows. Issue: Needs Refactor This issue needs a refactor to be solved. Size: Very Large For especially large issues/PRs. I pity you. Difficulty: 4-Irrational Best to just wait until someone else takes the bullet tbh. labels Nov 26, 2021
@Efruit
Copy link
Contributor

Efruit commented Nov 27, 2021

There's a bit of foundation for this in #2213.

Formatted text Sections have the option of including a Localized flag. The idea is that there would be an ISectionable proxy that sits in front of the real ISectionable (probably a FormattedMessage). If the proxy sees that flag set in the original message, it would be able to transparently replace the Section's content with the localized version before it hits the layout or display system.

No provisions for arguments yet since that's serialization stuff and that's Not My Department™... not that anyone would trust code I write for it anyway.

@Efruit Efruit mentioned this issue Dec 15, 2021
Closed
12 tasks
@Ygg01 Ygg01 mentioned this issue Oct 28, 2022
Merged
@Ygg01 Ygg01 mentioned this issue Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: UI Things like game screens, menus, and windows. Difficulty: 4-Irrational Best to just wait until someone else takes the bullet tbh. Issue: Needs Refactor This issue needs a refactor to be solved. Priority: 3-Not Required Size: Very Large For especially large issues/PRs. I pity you.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Efruit @gradientvera