Localize commands #3374
Merged
Localize commands #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ygg01
requested review from
RemieRichards,
PaulRitter,
gradientvera,
Acruid,
PJB3005 and
ZoldorfTheWizard
as code owners
|
Hrm, why is entityQuery failing on transform in Content.IntegrationTests? NVM. It was some intermittent failure. |
Ygg01
added
the
Status: Needs Review
PJB3005
reviewed
Oct 27, 2022
PJB3005
reviewed
Oct 27, 2022
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
- Change private to protected for reuse in child classes
ElectroJr
requested changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #2331 and stepping stone for #2273.
Just without too much complication. Rather than a custom data structure, adds an abstract
LocalizeCommandthat preservesIConsoleCommandinterface.LocalizeCommandstandardizes theIConsoleCommandlocalization tocmd-{Command}-{help/desc}forHelpandDescriptionrespectively.Related to space-wizards/space-station-14#5543 (Expect a commit there too as well).
Non-breakable change at first glance.