Rich text cleanup #2343
Closed
Rich text cleanup #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efruit
force-pushed
the
rich-text-cleanup
branch
from
c75fa7b
to
c2ce530
Compare
ElectroJr
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Fiy there is also some sort of issue with RichTextLabel fonts that this PR doesn't yet seem to have fixed. The issue I've noticed is that for whatever reason the verbs in the verb menu don't have their fonts applied (bold/italic/etc).
Maybe unrelated, but RichTextLabel._getFont() ignores the "font" style property. It does a TryGet but does nothing with it.
|
@ElectroJr Very nice catch. Haven't tested it yet, but I've included a fix in #2340 @ bc1454f |
Efruit
force-pushed
the
rich-text-cleanup
branch
from
c2ce530
to
61e9709
Compare
|
No luck, they're still style-less. But it did fix the tool status text! |
Efruit
force-pushed
the
rich-text-cleanup
branch
2 times, most recently
from
b36091f
to
808cfed
Compare
Efruit
force-pushed
the
rich-text-cleanup
branch
from
808cfed
to
b6d0e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes and requires #2340.(Since merged to master.)