-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserInterface/TextLayout: Add word splitting for rich text #2352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efruit
requested review from
Acruid,
PJB3005 and
ZoldorfTheWizard
as code owners
December 17, 2021 12:05
Efruit
force-pushed
the
rich-text-splitting
branch
from
December 17, 2021 12:07
c093273
to
fcfa18e
Compare
Efruit
commented
Dec 17, 2021
Efruit
changed the title
UserInterface/TextLayout: Add word splitting for rich text
[DNM] UserInterface/TextLayout: Add word splitting for rich text
Dec 18, 2021
Efruit
changed the title
[DNM] UserInterface/TextLayout: Add word splitting for rich text
UserInterface/TextLayout: Add word splitting for rich text
Dec 18, 2021
Might as well do it all in one place since things like text selection are going to need rune widths, and it was making `Layout` (and formerly `SubWordSplit`) do a ton of extra work.
Efruit
force-pushed
the
rich-text-splitting
branch
from
December 18, 2021 04:49
f0dfa94
to
467c8a7
Compare
… appears in a `Section`
...which it should have been this whole time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↑
Requires and includes #2351