Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spelling errors in backend.cc, reduce.t.cc, and exponent_aggregates_computation.cc #234

Closed
wants to merge 3 commits into from

Conversation

vipocenka
Copy link
Contributor

  1. backend.cc:

    • Fixed "varaible" → "variable" in a log message.
  2. exponent_aggregates_computation.cc:

    • Corrected multiple instances of "aggegate_term" → "aggregate_term" in function definitions and calls.
  3. reduce.t.cc:

    • Fixed "begginning" → "beginning" in multiple comments describing memory operations.

Are These Changes Tested?

These updates only correct spelling errors in comments and function names. No functional changes were made, so existing tests should continue to pass without modifications.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Enhancement

Checklist

  • Self-reviewed the changes.
  • Opened or linked an existing issue if applicable.

Impact

Impact: Low. These changes are limited to spelling corrections in comments and function names, with no effect on functionality.

@jacobtrombetta jacobtrombetta changed the title Fix spelling errors in backend.cc, reduce.t.cc, and exponent_aggregates_computation.cc chore: fix spelling errors in backend.cc, reduce.t.cc, and exponent_aggregates_computation.cc Jan 29, 2025
@jacobtrombetta
Copy link
Collaborator

Running the code format script should fix the failing CI test. See here: https://github.com/spaceandtimelabs/blitzar?tab=readme-ov-file#code-format. Tell me if you don't have nix installed and I can help out.

@rnburn rnburn mentioned this pull request Feb 13, 2025
@rnburn
Copy link
Collaborator

rnburn commented Feb 13, 2025

I copied these changes over to #246 and fixed the formatting. Thank you.

@rnburn rnburn closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants