-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fix membership check #510
Conversation
abf3ba9
to
8b22a0b
Compare
8b22a0b
to
9771a0e
Compare
@@ -33,15 +57,23 @@ pub(crate) fn final_round_evaluate_membership_check<'a, S: Scalar>( | |||
beta: S, | |||
columns: &[Column<'a, S>], | |||
candidate_subset: &[Column<'a, S>], | |||
multiplicities: &'a [i128], | |||
input_ones: &'a [bool], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: We still should have input_ones
be an argument to mirror verifier_evaluate.
let multiplicities = get_multiplicities::<S>(candidate_subset, columns); | ||
let alloc_multiplicities = alloc.alloc_slice_copy(multiplicities.as_slice()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always done? Should get_multiplicities
simply accept alloc
?
🎉 This PR is included in version 0.71.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr. Depends on the following PRs: - [x] #430 - [x] #482 - [x] #503 - [x] #506 - [x] #509 - [x] #510 Closes #394. # Please go through the following checklist - [x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular `!` is used if and only if at least one breaking change has been introduced. - [x] I have run the ci check script with `source scripts/run_ci_checks.sh`. # Rationale for this change We need to add sort merge inner joins. <!-- Why are you proposing this change? If this is already explained clearly in the linked issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Example: Add `NestedLoopJoinExec`. Closes #345. Since we added `HashJoinExec` in #323 it has been possible to do provable inner joins. However performance is not satisfactory in some cases. Hence we need to fix the problem by implement `NestedLoopJoinExec` and speed up the code for `HashJoinExec`. --> # What changes are included in this PR? - add `SortMergeJoinExec` - add `Column::rho` and `Table::add_rho_column` <!-- There is no need to duplicate the description in the ticket here but it is sometimes worth providing a summary of the individual changes in this PR. Example: - Add `NestedLoopJoinExec`. - Speed up `HashJoinExec`. - Route joins to `NestedLoopJoinExec` if the outer input is sufficiently small. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? Example: Yes. --> Will be.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.Rationale for this change
We want to let membership check gadget take care of multiplicity computation to reduce the amount of duplicates in the sort merge join code.
What changes are included in this PR?
See above.
Are these changes tested?
Yes.