Threshold alerts #49
Merged
Threshold alerts #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
louism517
commented
Jul 2, 2019
louism517
commented
- adds support for Threshold alerts (addresses Support for multi-threshold alerts #42)
nathmclean
requested changes
Jul 2, 2019
| }) | ||
| } | ||
|
|
||
| func TestResourceAlert_validateAlertConditions(t *testing.T) { |
There was a problem hiding this comment.
Update this test to also check for info, warn or severe
wavefront/resource_alert_test.go
Outdated
| tmpTargetID := "" | ||
|
|
||
| if os.Getenv("TF_ACC") == "true" { | ||
| tmpTarget, err = createTarget() |
There was a problem hiding this comment.
Is it possible to also create the tmp target within testAccCheckWavefrontAlert_threshold ? Then we don't need to worry about this check, creating it and tidying it up.
Thinking it the targetID can be retrieved from state within testAccCheckWavefrontThresholdAlertAttributes()
nathmclean
requested changes
Jul 3, 2019
| ok := false | ||
| for _, level := range []string{"severe", "warn", "info", "smoke"} { | ||
| if key == level { | ||
| ok = true |
There was a problem hiding this comment.
Should break here when setting ok to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.