Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TransactionalTree::generate_id() #1146

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Added TransactionalTree::generate_id() #1146

merged 1 commit into from
Aug 22, 2020

Conversation

pantonov
Copy link
Contributor

Added TransactionalTree::generate_id()

  • renamed PageCache::generate_id() to PageCache::generate_id_inner()
  • moved concurrency lock from PageCache::generate_id_inner() to Context::generate_id()
  • TransactionalTree::generate_id() uses PageCache::generate_id_inner() with lock obtained in stage(), thus avoiding deadlock
    and providing fix for Calling generate_id() in a transaction blocks #1139

@spacejam
Copy link
Owner

looks good! thanks :)

@spacejam spacejam merged commit c8578a0 into spacejam:master Aug 22, 2020
@spacejam
Copy link
Owner

released sled 0.34.3 that includes your change

@spacejam spacejam mentioned this pull request Jan 8, 2021
Closed
@kardeiz kardeiz mentioned this pull request Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pantonov @spacejam