[WIP] Use fetch_max
instead of bump_atomic_lsn
#1233
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant part of issue rust-lang/rust#48655 was resolved in rust-lang/rust#72324 so this PR should eventually fix the corresponding TODO in
pagecache
.This initial PR does some of the grind work of replacing
bump_atomic_lsn
.NOTE: I'm not familiar with Rust's atomics, so I don't know if SeqCst is actually what you want.
For
cargo test
, my OS (Windows 10, WSL) couldn't hole punch the heap, and I got a lot of 60 second timeouts. Also, the tests got stuck on my end at aroundtree_bug_39
, so I had to kill the process. It might be better on your end.