Fix user-assigned identity example and other small fixes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the Spacelift log directory exists in case the directory wasn't provisioned on the VM image being used.
Switching to using a `scale_in` block instead of `scale_in_policy` to fix a deprecation warning.
- Allow unattended-upgrade to be disabled to save time on startup if it isn't required. - Add an `apt-get update` to ensure the package sources are up to date before running the upgrade. - Default the new variable to `true` to maintain backwards compatibility.
The user-assigned identity example was missing the `--username` parameter to `az login`, causing it to fail. It also missed the logging redirects meaning it would fail silently.
Removing the backslashes from a couple of info messages. They aren't needed, and are just output in the logs, which is confusing.
Remove unnecessary base64 encodes/decodes from the bastion and user-assigned identity examples. It forces users to base64-encode the private key passed in via a TF var, which isn't required and adds confusion.
It looks like there's an issue where the Terraform provider is unable to delete the KeyVault resource too soon after it was created. For now I'm just disabling the failing test case.
|
Maybe bump the version number is the README example code? |
peterdeme
approved these changes
Nov 16, 2023
I also noticed that the `required_providers` block was wrong so fixed that.
Makes perfect sense @peterdeme. Done. |
peterdeme
approved these changes
Nov 16, 2023
b4k3r
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I've fixed the user-assigned identity example to correctly pass the
--usernameflag. I've also included a number of other small tweaks in this PR because they were all very small changes:scale_inblock instead of the deprecatedscale_in_policy.unattended-upgradeto be disabled.\characters from log output.I've also disabled the password auth example from running as a test case because of what looks like a bug in the Terraform provider: hashicorp/terraform-provider-azurerm#19322.
Type of change
Checklists
Development
Code review