node-split poc: move IdentityStates to separate package, add metadata for identity states

[kacpersaw]

Description

Closes #6509

• Moved IdentityStates to separate package called identity.
• Added metadata for identity states.
• Adjusted API to the new proto schema

Integration of identity package:

• activation/activation.go: Added import for identity package and updated identitiesStates initialization to use identity.NewIdentityStateStorage(). [1] [2]
• activation/interface.go: Updated Set method in IdentityStates interface to use identity.State and identity.StateInfoMetadata. [1] [2]
• activation/mocks.go: Updated mock methods for IdentityStates to use identity.State and identity.StateInfoMetadata. [1] [2] [3]
• activation/nipost.go: Updated identityStates initialization and refactored Set method calls to use the new identity package structures. [1] [2] [3] [4] [5] [6]

Refactoring identity state handling:

• activation/activation.go: Refactored Set method calls to use identity.State and appropriate metadata. [1] [2] [3] [4] [5] [6]
• activation/nipost.go: Modified getBestProof method to return an additional poetUrl parameter and updated related method calls. [1] [2] [3] [4]

Updates to gRPC server:

• api/grpcserver/v2alpha1/interface.go: Updated identityState interface to use identity.StateInfo. [1] [2]
• api/grpcserver/v2alpha1/mocks.go: Updated mock methods for identityState to use identity.StateInfo. [1] [2] [3]
• api/grpcserver/v2alpha1/smeshing_identities.go: Added import for identity package.

[codecov]

Codecov Report

Attention: Patch coverage is 29.13043% with 163 lines in your changes missing coverage. Please review.

Project coverage is 77.2%. Comparing base (05ba7fb) to head (e6dea00).
Report is 1 commits behind head on node-split-poc.

Files with missing lines	Patch %	Lines
identity/state.go	0.0%	89 Missing ⚠️
identity/identity.go	26.3%	55 Missing and 1 partial ⚠️
api/grpcserver/v2alpha1/smeshing_identities.go	5.8%	16 Missing ⚠️
activation/activation.go	94.1%	1 Missing ⚠️
activation/nipost.go	96.5%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           node-split-poc   #6510     +/-   ##
================================================
- Coverage            77.3%   77.2%   -0.2%     
================================================
  Files                 341     342      +1     
  Lines               45737   45822     +85     
================================================
+ Hits                35378   35385      +7     
- Misses               8246    8324     +78     
  Partials             2113    2113             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fasmat]

I find this approach quite error prone. Nothing guarantees that any State sets the corresponding metadata. Also metadata might be stored that isn't even applicable to the given state.

This could probably be improved by the use of generics, where State is a generic type and RetryingState, PoetRegisteredState etc. are the corresponding specific types.

Then the big conditional checks in the api package might also be avoidable.

[fasmat]

NIT: EpochID can be derived from LayerID so this could probably be simplified to

Suggested change

	func (s *StateStorage) AllEligibilities() map[types.NodeID]map[types.EpochID]map[types.LayerID][]types.VotingEligibility {
	func (s *StateStorage) AllEligibilities() map[types.NodeID]map[types.LayerID][]types.VotingEligibility {