Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build post-service Docker img in CI #136

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Oct 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #136 (68b6be4) into main (e609ef6) will decrease coverage by 0.26%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   93.97%   93.71%   -0.26%     
==========================================
  Files          22       22              
  Lines        2905     2913       +8     
==========================================
  Hits         2730     2730              
- Misses        175      183       +8     

see 1 file with indirect coverage changes

@poszu poszu force-pushed the build-post-service-docker-img branch from 8970ac1 to 233715f Compare October 19, 2023 07:35
@poszu poszu force-pushed the build-post-service-docker-img branch from 233715f to f0c1c30 Compare October 19, 2023 07:52
@poszu poszu marked this pull request as ready for review October 19, 2023 08:29
@poszu poszu requested a review from fasmat October 19, 2023 08:29
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also need postcli or the post-rs equivalent for PoST init as part of the docker image. In system tests we want to deploy the pod based on this image and then use kubectl exec to run the initialization process.

Wdyt?

.github/workflows/docker.yml Outdated Show resolved Hide resolved
@poszu
Copy link
Collaborator Author

poszu commented Oct 19, 2023

We probably also need postcli or the post-rs equivalent for PoST init as part of the docker image. In system tests we want to deploy the pod based on this image and then use kubectl exec to run the initialization process.

Wdyt?

Initializing POST data for system tests could be achieved with an init container that would run a postcli. There's no need to bundle them together in a single docker image in my opinion.

@poszu poszu enabled auto-merge (squash) October 19, 2023 09:44
@poszu poszu merged commit 6cedfa0 into main Oct 19, 2023
18 checks passed
@fasmat fasmat deleted the build-post-service-docker-img branch March 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants